After reviewing almost all code we wrote for 18 months, completing some 1’500 reviews, we want to share some recommendations and look at things we’d like to change.
After setting out to create a peer review culture we came up with a workflow and picked a tool (yes, Crucible) that would help us get there.
At Disy we review almost all the code we write. Here, we want to share why that was not always the case and how we started with code reviews.
There are a couple of things you should do to make code reviews successful. Chief among them, keep them brief, short, and focused. This is the story of how I fucked up on all these accounts and we still made it work.